My thought about reviewing code contributions:

Explaining what is wrong with a patch is both confrontational and not pointing the right way. A much better approach is to make a tangible change suggestion and explain why that is better.

In the end, both styles can bring up the same facts. However, the negative style punishes the contributor. The positive style can give the impression of walking with the contributor towards a better result.

0

If you have a fediverse account, you can quote this note from your own instance. Search https://floss.social/users/pq/statuses/115661137572360157 on your instance and quote it. (Note that quoting is not supported in Mastodon.)